Low-level API: transports' send_all_from_iterable() method are more efficient
#315
+83
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis-clairicia
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
francis-clairicia
deleted the
fix/lowlevel-api/transports/send-all-from-iterable-optimizations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Asynchronous API
AsyncStreamWriteTransport: Default implementation ofsend_all_from_iterable()consumes the iterable before trying to callsend_all()Synchronous API
StreamWriteTransport: Default implementation ofsend_all_from_iterable()consumes the iterable before trying to callsend_all()SocketStreamTransport.send_all_from_iterable(): Code cleanupSSLStreamTransport: Overridesend_all_from_iterable()to concatenate the given data and callsend_all()once.